add toolchain shims here #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* only added if no other toolchain is added * on linux shim through to llvm * on mac shim through to system rationale * reduces hacks in our infra * these are only used with pantry builds * brewkit controls that * everyone expects a C compiler, builds either will work with this or they need to be more specifiuc * for end users removes the surprise of `cc` being some weird hack * end users have to control rpaths themselves and if they are going that low-level then they know what to do * magic is bad
|
while I think this is the right approach I note that Thus the above approach is not adequate, instead we will need to dynamically create symlinks on linux that point to the installed llvm. I'll consider whether this is sensible in advance of v1.0 next week. I'm thinking: no: there are too many moving parts already. |
|
the failure is fixed in tea/cli v1 |
mxcl
added a commit
that referenced
this pull request
Sep 29, 2023
* add toolchain shims here * only added if no other toolchain is added * on linux shim through to llvm * on mac shim through to system rationale * reduces hacks in our infra * these are only used with pantry builds * brewkit controls that * everyone expects a C compiler, builds either will work with this or they need to be more specifiuc * for end users removes the surprise of `cc` being some weird hack * end users have to control rpaths themselves and if they are going that low-level then they know what to do * magic is bad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rationale
ccbeing some weird hack