Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add display-name: to TEMPLATE.pkg.yml #184

Merged
merged 1 commit into from
Oct 8, 2023
Merged

add display-name: to TEMPLATE.pkg.yml #184

merged 1 commit into from
Oct 8, 2023

Conversation

jhheider
Copy link
Contributor

@jhheider jhheider commented Oct 8, 2023

fixes #183

@jhheider jhheider requested a review from mxcl October 8, 2023 00:39
@@ -23,6 +23,12 @@ distributable:
url: git+https://github.com/user/repo
ref: v{{version}}}

# if omitted, most tools will work by looking at either the provides: list, or require the
# fully-qualified name of the package. providing a display-name looks better in `pkgxdev/ossapp`
# and allows simpler commands like `pkgx install common-package-name`. this _should never_ conflict
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hah. yes true

@mxcl mxcl merged commit e57f02c into main Oct 8, 2023
@mxcl mxcl deleted the display-name-template branch October 8, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add display-name to the sample manifest
2 participants