Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make cache dir to prevent build failures #267

Merged
merged 1 commit into from
Jan 11, 2024
Merged

make cache dir to prevent build failures #267

merged 1 commit into from
Jan 11, 2024

Conversation

mxcl
Copy link
Member

@mxcl mxcl commented Jan 11, 2024

Some tools don’t think to mkdir -p directories that are usually there. Refs pkgxdev/pantry#4807

@mxcl
Copy link
Member Author

mxcl commented Jan 11, 2024

glad I added the test. Indeed the config.cache is unused and is the original user cache since I was thinking we should try to cache some stuff (specifically LLM models so we could run more tests on AI shit).

But I never did that.

Possibly it's not a terrible idea to have this set to user cache, it would speed up builds at the cost of occasional issues since you can't trust software to do caching properly.

Anyway will fix this so we create the cache dirs for our test environments.

Some tools don’t think to `mkdir -p` directories that are usually there.
Refs pkgxdev/pantry#4807
@mxcl mxcl merged commit 2c169f4 into main Jan 11, 2024
33 checks passed
@mxcl mxcl deleted the mkdir-p-cache branch January 11, 2024 19:20
@codablock
Copy link

fyi, the bug that caused the panic on the missing ~/.cache dir has been fixed in a later kluctl release. If you don't assume other tools have such bugs, you can remove this fix again.

@mxcl
Copy link
Member Author

mxcl commented Jan 17, 2024

Thanks @codablock!

If you don't assume other tools have such bugs, you can remove this fix again.

We'll leave it as we prefer things to just work and I know how easy it is to miss the possibility that a directory that is almost always there may not be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants