Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getReader().read() only returns the first line #271

Merged
merged 1 commit into from
Jan 13, 2024
Merged

getReader().read() only returns the first line #271

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions lib/hooks/usePantry.getVersions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,9 +305,7 @@ async function handleTransformer(transform: string, versions: string[]): Promise
`));
await writer.close()

const read = cmd.stdout.getReader().read().then(x => x.value)

const [out, { success: ok }] = await Promise.all([read, cmd.status])
const { stdout: out, success: ok } = await cmd.output()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the docs imply you should await cmd.status but if it works maybe not then.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulled that example out of the current docs, I believe. I'll add the reference.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://docs.deno.com/runtime/tutorials/subprocess#simple-example


if (!ok) throw new Error("failed to run version transformer")

Expand Down
Loading