Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bk docker and bk edit #318

Merged
merged 2 commits into from
Mar 9, 2024
Merged

Fix bk docker and bk edit #318

merged 2 commits into from
Mar 9, 2024

Conversation

felipecrs
Copy link
Contributor

@felipecrs felipecrs commented Mar 7, 2024

@jhheider
Copy link
Contributor

jhheider commented Mar 7, 2024

looks like #314; thought i'd searched for others, but everything (seemed) to work. we should double-check this is the last one.

@felipecrs felipecrs changed the title Fix brewkit source mount within bk docker Fix bk docker and bk edit Mar 8, 2024
@felipecrs
Copy link
Contributor Author

Good point. I fixed bk-edit (which I had spotted in #316), and that was the last shell script with such a reference.

But if you search for ../.. you can find some other references in ts files. I would suggest you give it a search yourself, as I'm not as familiar as you with this code base.

There's this one for example:

https://github.com/felipecrs/brewkit/blob/031b62dfe41d4aedd6a8e8e2cbd1370d97d87384/lib/porcelain/fix-up.ts#L15

@jhheider
Copy link
Contributor

jhheider commented Mar 8, 2024

Looking through, bk-edit and bk-docker look like the only ones. The .ts files are all clearly working, but the bk-command files are half for end-users. I think those are the only two.

@jhheider jhheider requested a review from mxcl March 8, 2024 01:12
@mxcl
Copy link
Member

mxcl commented Mar 9, 2024

I thought we'd already had this fix. Apparently not?

Or possibly the “fix” was the opposite.

I must have an oldish version of brewkit installed or something as I’ve been using both these commands without trouble.

@mxcl mxcl merged commit e0f7006 into pkgxdev:main Mar 9, 2024
33 checks passed
@jhheider
Copy link
Contributor

I think I missed these when I fixed bk-init for an issue. Hopefully, we've found them all now.

felipecrs added a commit to felipecrs/brewkit that referenced this pull request Apr 1, 2024
* Fix brewkit source mount within bk docker

Refs pkgxdev/pantry#5472 (comment)

* Fix bk edit
felipecrs added a commit to felipecrs/brewkit that referenced this pull request Apr 1, 2024
* Fix brewkit source mount within bk docker

Refs pkgxdev/pantry#5472 (comment)

* Fix bk edit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants