Faster test"

pkgxdev · Oct 4, 2023 · ea72274 · ea72274
1 parent b43c53b
commit ea72274
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/.github/workflows/build-sign-notarize.yml b/.github/workflows/build-sign-notarize.yml
@@ -55,6 +55,7 @@ jobs:
     if: needs.verify.outputs.is-updated == 'true'
     runs-on: macos-latest
     outputs:
+      # just the postfix of the key, not the full key, github does not allow output of secrets
       s3-artifacts-key: ${{ steps.s3-artifact-uploader.outputs.key }}
       build-version: ${{ steps.gui-version.outputs.version }}
     steps:
@@ -135,6 +136,4 @@ jobs:
         run: |
           S3_KEY=$bucket/$prefix/artifacts.tgz
           aws s3 cp artifacts.tgz $S3_KEY
-          echo "key=$S3_KEY" >> $GITHUB_OUTPUT
-          echo "$S3_KEY"
-          echo $GITHUB_OUTPUT
+          echo "key=$prefix/artifacts.tgz" >> $GITHUB_OUTPUT
diff --git a/.github/workflows/temp.yml b/.github/workflows/temp.yml
@@ -20,6 +20,7 @@ jobs:
     secrets: inherit
   upload:
     needs: [build_desktop]
+    if: needs.build_desktop.outputs.s3-electron-dist-key != ''
     runs-on: ubuntu-latest
     strategy:
       matrix:
@@ -36,7 +37,7 @@ jobs:
           aws-region: us-east-1
       - name: s3 artifact download
         env:
-          S3_INSTALLER_KEY: ${{ needs.build_desktop.outputs.s3-electron-dist-key }}
+          S3_INSTALLER_POST_KEY: ${{ secrets.BUILDS_S3_BUCKET }}/${{ needs.build_desktop.outputs.s3-electron-dist-key }}
         run: aws s3 cp $S3_INSTALLER_KEY dist.tgz
 
       - run: |