zsh autocomplete

[jhheider]

This works. The places I think it might need love:

• it will be slow. and ever slower. useSync should cache all the provides to the sqlite store for much faster performance.
• it wasn't in any way clear to me how to interleave our completions with zsh's defaults. possibly because we don't work like anything else
  • one possibility is to do the path scanning ourselves, so we can just do the whole completion stack. this will also take time, and want for caching.

[what-the-diff]

PR Summary

• Addition of complete Function in a New File
  A new file named app.complete.ts was created, which houses an asynchronous function complete(). It takes a prefix as an argument and carries out operations based on the given prefix.

• Modification of Available Options in Help
  In the app.help.ts file, the list of available options was updated. Specifically, a new option --complete <prefix> was added and the --provides option was removed.

• Inclusion of New Functions in app.magic.ts
  Several new functions were added to the app.magic.ts to enhance the functionality of the application. These functions check conditions, handle missing commands, generate possible names for binaries, and set up command-line completion.

• Integration of complete Function in the Main Application
  In the app.main.ts file, the newly added complete function is imported and used in a unique case for the "complete" mode.

• Updating the Args Type with a New Mode
  The Args type found in src/args.ts was expanded to include a new mode, "complete". A new property complete was also added to the Args interface.

• Testing for the "complete" Mode
  Tests to ensure the correct operation of the "complete" mode were added in tests/functional/run.test.ts.

[jhheider]

Those errors are a little thorny. Looks like our zsh package might need:

runtime:
  env:
    FPATH: ${{prefix}}/functions
    MODULE_PATH: ${{prefix}}/lib/zsh/{{version.marketing}}

or similar...

[jhheider]

I believe pkgxdev/pantry#2132 will fix this PR, if it's deemed an acceptable solution.

[mxcl]

why is this dependent on our zsh? zsh comes with mac. Yes, our zsh should work, and linux ofc. But we should be able to add this without fixing zsh and looking at my current schedule I will not be able to fix zsh for weeks.

[jhheider]

Probably because of how our tests work. I'll see if I can fix the test.

Was trying to avoid removing a test that caught a real issue to push code through.

[jhheider]

pkgxdev/pantry#2132 should do it.

[jhheider]

Confirmed, and zsh fixed in the bargain. Ready for critique!

[mxcl]

Tried it and it works!

$ py
pygmentize        pyproject-build   python            
pylsp             pytest            python\{\{        
python                               python\{\{\ version.major\ \}\}
python3                              python\{\{\ version.marketing\ \}\}

needs some moustache expansion.

$ git cl
clang          clear          cluster        
clang++        clippy-driver  clusterdb      
clean -- remove untracked files from working tree
clone -- clone repository into new directory

Seems we are completing any time TAB is pressed.

[mxcl]

even if we use sqlite having to use tea will add 80ms to all completion which sucks

[mxcl]

Can we have tea completions in teal?

[jhheider]

Can we have tea completions in teal?

worth a try, certainly.

[jhheider]

needs some moustache expansion.

Hm. Might just need to omit mustachioed variants. Otherwise, we'd need to do produce them for every version available...

Seems we are completing any time TAB is pressed.

That we should not do. Probably something I missed about detecting context.

[jhheider]

the docs for zsh completion are long but not amazing.

[jhheider]

colorizing the results eluded me. i believe everything else is addressed.

[mxcl]

colorizing the results eluded me

was a nice to have, not required. good job trying tho

[mxcl]

So trying it out, being able to distinguish between what is on the system and what is not yet on the system is pretty important IMO.

We either need coloration or to make the results appear completely separately to system results

[jhheider]

Zsh completion has a grouping system. I wasn't able to properly group output (complicated, like I said), but supposedly it can be done by tags, then print a header for each section.

I go back and forth about the import. If the point is to be magical, then not showing the difference seems like the right way. If they cared about local vs tea installed, they wouldn't use magic, right?

[mxcl]

I go back and forth about the import. If the point is to be magical, then not showing the difference seems like the right way. If they cared about local vs tea installed, they wouldn't use magic, right?

it's a good point.

Let's just merge and see how it feels for a few weeks I guess.