Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPG sign binaries; include pubkey in srcs #636

Merged
merged 2 commits into from
Jul 10, 2023
Merged

GPG sign binaries; include pubkey in srcs #636

merged 2 commits into from
Jul 10, 2023

Conversation

jhheider
Copy link
Contributor

wip


wip


wip


cleanup


add these back
@what-the-diff
Copy link

what-the-diff bot commented Jul 10, 2023

PR Summary

  • Enhancement in Security Measures
    The update focuses on signing the archive with GPG before it's uploaded. This step empowers the integrity and security of the archive, ensuring the artifact is unchanged and authentic since the moment of signing.

  • Inclusion of GPG Pubkey in the Bundle Source
    The update also incorporates the GPG public key into the bundle source prior to the creation of the tar.xz file. This facilitates verification of the file after download, serving as a guarantee that it hasn't been tampered with after creation.

@mxcl
Copy link
Member

mxcl commented Jul 10, 2023

I'm an idiot, we need signatures for each of the tarballs, not the binary.

Most projects aren’t single binary projects and we want this to be generalized.

@jhheider
Copy link
Contributor Author

should be an easy enough change

@mxcl
Copy link
Member

mxcl commented Jul 10, 2023

there's gotta be a simpler gpg clone we can start using.

needing a daemon is dumb

@mxcl mxcl merged commit f4977e2 into main Jul 10, 2023
@mxcl mxcl deleted the gpg-sign branch July 10, 2023 20:04
@jhheider
Copy link
Contributor Author

Agreed. required as of gpg2 sadly. I mean, the safety of requiring actual passwords, and having a daemon deal with credential management was likely a well-considered decision, but it's overkill for this use case.

@mxcl
Copy link
Member

mxcl commented Jul 11, 2023

have we published our GPG public key in a standard location?

I would have thought https://tea.xyz/KEY (but not KEY) is a standard of some sort.

@jhheider
Copy link
Contributor Author

we haven't and I just regenerated it because we had been signing with my jacob@tea.xyz key.

the standard is usually to publish to public key servers. In the web3 space, I usually see it prominently mentioned alongside download locations so concerned individuals can check it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sign tea binaries with the tea.inc. GPG key and attach to the release
2 participants