Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix UTF-8 cli args to exec #638

Merged
merged 2 commits into from
Jul 10, 2023
Merged

fix UTF-8 cli args to exec #638

merged 2 commits into from
Jul 10, 2023

Conversation

jhheider
Copy link
Contributor

@jhheider jhheider commented Jul 10, 2023

We need the actual buffer size, instead of string length. Slower, but otherwise we risk truncating input.

Example of failure in action: https://github.com/teaxyz/pantry/actions/runs/5506185252/jobs/10042047292

stage.ts is copying from a non-existent unpack directory, resulting in no source. see also the tarball ending in tar.g.

@jhheider jhheider requested a review from mxcl July 10, 2023 19:08
@what-the-diff
Copy link

what-the-diff bot commented Jul 10, 2023

PR Summary

  • Improved String Length Calculation
    The method for determining the length of strings in our software has been enhanced. Previously, the program was just counting the number of characters, but now it's looking at the entire encoded length of the string. This change will improve string handling especially when dealing with complex characters.

  • Additional Test for UTF-8 Argument Handling
    We've added a new test into the software's suite to verify that specific coding language constructs (shebangs in this case) can properly handle arguments in UTF-8 format. This new check will ensure our handling of diverse character sets remains robust. The test executes a sample script, then verifies that the output matches what we're expecting.

@mxcl mxcl merged commit 3aab356 into main Jul 10, 2023
@mxcl mxcl deleted the fix-UTF-8-args branch July 10, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants