Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log query errors through tracing crate #92

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Log query errors through tracing crate #92

merged 1 commit into from
Jul 23, 2024

Conversation

pkolaczk
Copy link
Owner

No description provided.

@pkolaczk pkolaczk marked this pull request as draft July 22, 2024 17:46
@pkolaczk
Copy link
Owner Author

pkolaczk commented Jul 22, 2024

CC: @vponomaryov this is unfinished, but this should allow you to intercept query errors while running. Let me know what you think.

@pkolaczk pkolaczk marked this pull request as ready for review July 23, 2024 10:21
@pkolaczk pkolaczk merged commit fed0bd4 into main Jul 23, 2024
4 checks passed
@pkolaczk pkolaczk deleted the logging branch July 23, 2024 10:26
@vponomaryov
Copy link
Contributor

CC: @vponomaryov this is unfinished, but this should allow you to intercept query errors while running. Let me know what you think.

Lots of stress tools print out errors into the same output as the general stats.
Cassandra-stress is one of such popular tools.
We find this approach useful and prefer it.
Having a separate file for stats and another one for errors just makes us do data aggregation or spend more time for matching time slots when something (controlled disruptions) goes wrong (always).
Errors are valuable in conjunction to the growing latencies of OK stats too.

So, lots of new features are interesting to have.
But, from our point of view, we get too big regressions which make us think about switch from sync fork to origin to backport interesting changes to our fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants