Changed backspace behaviour to remove the last input when focus is on an empty input #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hi @JopMaarse, Thank you for opening your pull request! Previously, there was a request not to automatically delete the input value. The library included a setting to control this behavior before version 1.0.0, but I did not reintroduce that option during the refactor. I think we could consider adding this option back and keep both behaviors. What are your thoughts? |
|
An option to choose the behaviour seems perfectly fine to me. Do you need me to change the pull request, or will you take it from here? If you want me to change it, can you link to the commit that removed the option? |
|
I can take it from here, thank your very much for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you are focused on an empty input and press backspace, the focus changes to one index lower, but that input value is not removed. Then when you type a new value, nothing happens.
This change makes it so that when you press backspace on an empty input field, the last value is removed.