Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkp/pkp-lib#5504 Control access to settings by user group #4431

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

pkp/pkp-lib#5504 Control access to settings by user group #4431

wants to merge 4 commits into from

Conversation

asmecher
Copy link
Member

@asmecher asmecher commented Sep 9, 2024

No description provided.

@asmecher asmecher mentioned this pull request Sep 9, 2024
Open
@asmecher asmecher force-pushed the i5504-fix branch 3 times, most recently from 31b0b44 to 8bcc459 Compare September 13, 2024 21:21
@asmecher asmecher marked this pull request as ready for review September 13, 2024 21:27
bozana
bozana reviewed Sep 30, 2024
View reviewed changes
Copy link
Contributor

@bozana bozana left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @asmecher, the same/similar comment as in PKP-LIB PR...
Thanks a lot!

EDIT: are we supposed to commit pkp.min.js? 🤔

registry/userGroups.xml Outdated Show resolved Hide resolved
@asmecher
Copy link
Member Author

EDIT: are we supposed to commit pkp.min.js? 🤔

Yes, we rarely modify those scripts these days, but it's a good habit when we do. (The build process will catch us if we forget, though.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bozana bozana bozana left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asmecher @bozana