Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long affiliations should be wrapped in backend (bad UI/UX) #10451

Open
mpbraendle opened this issue Sep 19, 2024 · 0 comments
Open

Long affiliations should be wrapped in backend (bad UI/UX) #10451

mpbraendle opened this issue Sep 19, 2024 · 0 comments
Assignees
Labels
Bug:2:Moderate A bug that is causing problems for a substantial minority of users. Try Me This issue might be good for a new contributor. Can you help us? UI/UX Issues affecting the user interface/user experience
Milestone

Comments

@mpbraendle
Copy link
Contributor

mpbraendle commented Sep 19, 2024

Describe the bug
In the backend, long affiliations of contributors shift the buttons for editing a contributor out of focus of the browser window. UI/UX must be improved to not have to scroll horizontally. CSS should be applied to the .listPanel__itemSubtitle class to wrap the affilation, e.g. such as

.listPanel__itemSubtitle {
white-space: normal !important;
}

In addition, the affiliation field of a contributor is too small (just 20em) and hinders editing within the affiliation. Either make it as wide as the enclosing popup window (minus a small border to the left and right, e.g. width: 100%) or provide input textbox instead of a input text field.

To Reproduce

  1. Go to the publication tab of a submission.
  2. Edit a contributor, contributor, enter a long affiliation and save.
  3. In the list of contributors, all buttons to edit a contributor get out of focus and it must be scrolled horizontally to reach them.
  4. Edit the contributor, try to edit the affiliation again by inserting or deleting text at some position within an affilation.

What application are you using?
OJS 3.4.0-5 (but probably also applies to OJS 3.3)

Additional information
long_affiliations


Development Updates

Changes made:

  1. Wrapped the ContributorsPanel's author and affiliation data using CSS rules white-space: normal
  2. Made the Affiliations field in full width for both main and 3.4 versions.

Notes:
v3.3 is not affected by this issue as the affiliations column is not shown in the Contributors list, and the Affiliation text field is longer than the normal size of our text fields.


Pull Requests:

main

ui-library: pkp/ui-library#420 (merged)
pkp-lib: #10503 (merged)

(submodule updates)
ojs: pkp/ojs#4460 (closed)
omp: pkp/omp#1718 (closed)
ops: pkp/ops#785 (closed)


stable-3_4_0

ui-library: pkp/ui-library#419
pkp-lib: #10504
ojs; pkp/ojs#4458

(submodule updates)
omp: pkp/omp#1717
ops: pkp/ops#784

@jardakotesovec jardakotesovec added Try Me This issue might be good for a new contributor. Can you help us? Bug:2:Moderate A bug that is causing problems for a substantial minority of users. UI/UX Issues affecting the user interface/user experience labels Sep 19, 2024
@jardakotesovec jardakotesovec added this to the 3.4.0-8 milestone Sep 19, 2024
blesildaramirez added a commit to blesildaramirez/ui-library that referenced this issue Oct 2, 2024
blesildaramirez added a commit to blesildaramirez/ojs that referenced this issue Oct 2, 2024
blesildaramirez added a commit to blesildaramirez/ojs that referenced this issue Oct 3, 2024
blesildaramirez added a commit to blesildaramirez/ui-library that referenced this issue Oct 3, 2024
blesildaramirez added a commit to blesildaramirez/ui-library that referenced this issue Oct 3, 2024
blesildaramirez added a commit to blesildaramirez/ojs that referenced this issue Oct 3, 2024
blesildaramirez added a commit to blesildaramirez/ojs that referenced this issue Oct 3, 2024
blesildaramirez added a commit to blesildaramirez/pkp-lib that referenced this issue Oct 3, 2024
blesildaramirez added a commit to blesildaramirez/ojs that referenced this issue Oct 3, 2024
blesildaramirez added a commit to blesildaramirez/pkp-lib that referenced this issue Oct 3, 2024
blesildaramirez added a commit to blesildaramirez/ojs that referenced this issue Oct 3, 2024
blesildaramirez added a commit to blesildaramirez/ui-library that referenced this issue Oct 3, 2024
blesildaramirez added a commit to blesildaramirez/ui-library that referenced this issue Oct 3, 2024
blesildaramirez added a commit to blesildaramirez/pkp-lib that referenced this issue Oct 3, 2024
blesildaramirez added a commit to blesildaramirez/ojs that referenced this issue Oct 3, 2024
blesildaramirez added a commit to blesildaramirez/omp that referenced this issue Oct 3, 2024
blesildaramirez added a commit to blesildaramirez/omp that referenced this issue Oct 3, 2024
blesildaramirez added a commit to blesildaramirez/ops that referenced this issue Oct 3, 2024
blesildaramirez added a commit to blesildaramirez/omp that referenced this issue Oct 3, 2024
blesildaramirez added a commit to blesildaramirez/ops that referenced this issue Oct 3, 2024
blesildaramirez added a commit to blesildaramirez/ui-library that referenced this issue Oct 16, 2024
blesildaramirez added a commit to blesildaramirez/ojs that referenced this issue Oct 16, 2024
blesildaramirez added a commit to blesildaramirez/omp that referenced this issue Oct 16, 2024
blesildaramirez added a commit to blesildaramirez/ops that referenced this issue Oct 16, 2024
blesildaramirez added a commit to pkp/ui-library that referenced this issue Oct 16, 2024
…nd (bad UI/UX) (#420)

* pkp/pkp-lib#10451 Add whitespace-normal class to display affiliations in full

* pkp/pkp-lib#10451 Add stories for contributors list panel
blesildaramirez added a commit to blesildaramirez/ops that referenced this issue Oct 16, 2024
blesildaramirez added a commit to blesildaramirez/ui-library that referenced this issue Oct 16, 2024
blesildaramirez added a commit to blesildaramirez/ops that referenced this issue Oct 16, 2024
blesildaramirez added a commit to blesildaramirez/omp that referenced this issue Oct 16, 2024
blesildaramirez added a commit to blesildaramirez/ojs that referenced this issue Oct 16, 2024
asmecher pushed a commit to pkp/ui-library that referenced this issue Oct 21, 2024
…in backend (bad UI/UX) (#419)

* pkp/pkp-lib#10451 Add full-text class in ListPanel component to fix issue with long text in table

* pkp/pkp-lib#10451 Isolate full-text class for ContributorsListPanel component

* pkp/pkp-lib#10451 Fix eslint problem on ContributorsListPanel component
asmecher pushed a commit to pkp/ojs that referenced this issue Oct 21, 2024
ipula pushed a commit to ipula/ui-library that referenced this issue Oct 22, 2024
…nd (bad UI/UX) (pkp#420)

* pkp/pkp-lib#10451 Add whitespace-normal class to display affiliations in full

* pkp/pkp-lib#10451 Add stories for contributors list panel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug:2:Moderate A bug that is causing problems for a substantial minority of users. Try Me This issue might be good for a new contributor. Can you help us? UI/UX Issues affecting the user interface/user experience
Projects
None yet
Development

No branches or pull requests

3 participants