pkp/pkp-lib#5504 Control access to settings by user group #10380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asmecher
force-pushed
the
i5504-fix
branch
6 times, most recently
from
28c3df4
to
2113c29
Compare
bozana
reviewed
Sep 30, 2024
There was a problem hiding this comment.
Hi @asmecher, just one comment, I think.
Maybe also a question, to double check, if we should consider CanAccessSettingsPolicy in:
OJS SubscriptionsGridHandler
LanguageGridHandler
SubmissionLanguageGridHandler
What about other API Controllers, e.g. institution, highlights, emailTemplates, invitations?
(And, nothing for this PR -- I see the other/similar options are handled in the same way -- but I am wondering if some login from the UserGroupFormHandler.js should actually go somewhere else... 🤔 )
Thanks a lot!
js/controllers/grid/settings/roles/form/UserGroupFormHandler.js
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.