Update to Postgres 17 #54
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pksunkara
requested changes
Dec 5, 2024
| @@ -1,5 +1,5 @@ | |||
| comment = 'ulid type and methods' | |||
There was a problem hiding this comment.
Why are we renaming the extension?
There was a problem hiding this comment.
I'm only renaming the crate, because of the conflict, the build will generate a package that will provide 100% compatibility with the old name, so it won't break any existing Postgres extension
| @@ -1,30 +1,32 @@ | |||
| [package] | |||
| name = "ulid" | |||
| name = "pgx_ulid" | |||
There was a problem hiding this comment.
You shouldn't have a name conflict at all. Can you please describe the issue more?
There was a problem hiding this comment.
pgrx is trying to load the dynamic library ulid.so, but it is encountering the one from the ulid package and not from our extension, so I've renamed the crate to avoid any conflicts with the libraries generated
| } | ||
| } | ||
| let inner = InnerUlid::from_string(val) | ||
| .unwrap_or_else(|err| panic!("invalid input syntax for type ulid: \"{val}\": {err}")); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a big PR, to make it work with PG17 I had to rewrite many of the automatic functions from derive manually, but it works wonders with the latest version of Postgres. The biggest problem is the name conflict with the ulid package