Alignment w/mainline & Core, RPC, P2P improvements #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Everywhere, more aggressively check for missing peers. * Everywhere, more aggressive locking. * addrmgr: Align our defaults closer to modern Bitcoin Core. * calcEasiestDifficulty removed completely, unneeded. * connmgr: Align our defaults closer to modern Bitcoin Core. * netsync: Announce new transactions via PeerNotifier only when we actually have accepted new transactons. * netsync: More aggressively attempt to maintain sync peers. * peer: Ignore proxy and tor checks in tests for reliability. I believe I already completely removed this in an earlier PR. * server.go: Align closer with Bitcoin Core, also, and fix up some of the logic in the address cache, should make some tests (like #128) more robust. * Use Go's HTTP/2 support for JSON-RPC to support keepalives, etc. Brings us closer to the other implementations (such as Bitcoin Cash, pending in Core), and allows for removing a lot of code. * Fix bug that was causing help to be shown twice while I was there. * Remove alerts - they've been gone from Bitcoin Core forever. * Fix up and explicitly de-parallelize some of the tests. * Remove block fastAdd processing in processBlock. * Message peers even on orphan blocks as they might be from a reorg.
|
Regression test shows I broke something here, will fix and resubmit correction, probably as separated PR's |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everywhere, more aggressively check for missing peers.
Everywhere, more aggressive locking.
addrmgr: Align our defaults closer to modern Bitcoin Core.
calcEasiestDifficulty removed completely, unneeded.
connmgr: Align our defaults closer to modern Bitcoin Core.
netsync: Announce new transactions via PeerNotifier only when we actually have accepted new transactions.
netsync: More aggressively attempt to maintain sync peers.
peer: Ignore proxy and tor checks in tests for reliability. (I believe I already completely removed this in an earlier PR.)
server.go: Align closer with Bitcoin Core, also, and fix up some of the logic in the address cache, should make some tests (like Yet another flaky test (or a flaky function!) causing rare failures. #128) more robust.
Use Go's HTTP/2 support for JSON-RPC to support keep-alives, etc. Brings us closer to the other implementations (such as Bitcoin Cash, pending in Core), and allows for removing a lot of code.
Remove alerts completely - they've been gone from Bitcoin Core forever.
Fix up and explicitly de-parallelize some of the tests.
Remove block fastAdd processing in processBlock.
Message peers even on orphan blocks as they might be from a reorg.
Fix the bug in pktctl that causes help to be shown twice.