Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there something I'm missing? #15

Closed
Marcusgeorgiadis opened this issue Mar 10, 2023 · 5 comments
Closed

Is there something I'm missing? #15

Marcusgeorgiadis opened this issue Mar 10, 2023 · 5 comments

Comments

@Marcusgeorgiadis
Copy link

I cannot get good results with this in i2i upscaling. Outputs are decent, but seemingly not better than ultimate SD upscale. Can you give some example settings for upscaling? And give annotations to settings explaining what they do?

Also have no idea how to properly apply this in t2i.

@LightChaser666
Copy link
Collaborator

Thanks for your feedback. Please refer to another issue, where we have tons of discussion on how to use it well.

Personally speaking MultiDiffusion for upscale is more difficult to use than Ultimate Upscaler because the latter preserves details with post-processing. MultiDiffusion is a completely redraw, so it largely depends on your checkpoint and your settings for img2img. With a good checkpoint (better not pruned) it can achieve amazing and desirable results.

So if you are not very experienced in img2img you may need to try it more.

@Marcusgeorgiadis
Copy link
Author

I have referenced the examples in the other threads, they only use anime as examples. For anime it's not hard to upscale.

I'm experienced in i2i, I just don't see how this is any better than ultimate SD upscale.

Just need more comprehensive instructions. Some settings are intuitive, some I have no clue what they do.

@jurandfantom
Copy link

jurandfantom commented Mar 11, 2023

Here is example @Marcusgeorgiadis
Problem with that extension (and upscale in general) is fact that everything change a lot. Today i was checking all samplers to find best one and end up with ranking that depends from situation. Attached picture shows exactly what I talk about, left is MultiDiffusion when right is Ultimate.
23,03,11 - 18,25,32 - 7341 a

Here is best attempt with Ultimate as comparison point for above picture. What is better/worse? hard to say, only thing that matter is output please you or not. Apply everything as we do in other topic and consider that as best starting point. Everything change results a lot, SD model, upscaler, sampler, type of extension + CFG/Denoiser. Try find mix that please you as that or other extension is not silver bullet (that one is way faster )

23,03,11 - 21,49,01 - 7348 a

@pkuliyi2015
Copy link
Owner

pkuliyi2015 commented Mar 12, 2023

Here is example @Marcusgeorgiadis Problem with that extension (and upscale in general) is fact that everything change a lot. Today i was checking all samplers to find best one and end up with ranking that depends from situation. Attached picture shows exactly what I talk about, left is MultiDiffusion when right is Ultimate.

The key point is that I need a user interface to draw bbox, so that you can draw rectangles and control the MultiDiffusion with different prompts. In this way the result should get way better.

Why? because in this way you can just select the woman's face and tell SD to draw a beautiful woman's face. Then the SD will try his best, using his 512 * 512 resolution to ONLY draw a face. The resolution will be unprecedentedly high for SD models, as he dedicated to draw only one part of the image at the best of his capabilities.

However, when I was adding features I saw this f**king issue:
gradio-app/gradio#2316

Some one pr a bbox tool but the officials denied the merging:
gradio-app/gradio#3220

I don't know what are they thinking in mind to deny such a good PR (from my perspective) but don't provide their own solutions. It has been a half year since it was first proposed.

So it will be hard to draw rectangles on images directly. I must find another way to draw rectangles. Do you have any other idea?

@pkuliyi2015
Copy link
Owner

Please try again in this version. The problem should be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants