Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Bounding-Box tool for Image Component #3220

Closed
wants to merge 9 commits into from
Closed

Added Bounding-Box tool for Image Component #3220

wants to merge 9 commits into from

Conversation

CtrlAltDeplete
Copy link

@CtrlAltDeplete CtrlAltDeplete commented Feb 17, 2023

Description

This change adds a new tool to the Image component: boxes. This tool allows users to draw boxes on an image as part of the input, which are passed along as an Array of Arrays of number (top, left, bottom, right).

This is useful in applications where one image has multiple points of interested, and needs to be broken down into multiple inputs, whereas the existing crop would require users to upload the same image for each input. Additionally, this could be used in a similar way as the mask capability but gives users a box-shaped tool, so they don't have to draw shaky lines.

Checklist:

  • I have performed a self-review of my own code
  • I have added a short summary of my change to the CHANGELOG.md
  • My code follows the style guidelines of this project
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@gradio-pr-bot
Copy link
Collaborator

The demo notebooks don't match the run.py files. Please run this command from the root of the repo and then commit the changes:

pip install nbformat && cd demo && python generate_notebooks.py

@gradio-pr-bot
Copy link
Collaborator

All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-3220-all-demos

@abidlabs
Copy link
Member

Thanks for opening this PR @CtrlAltDeplete! We will take a look at this and get back on the next steps

@pngwn
Copy link
Member

pngwn commented Feb 21, 2023

Hey @CtrlAltDeplete, thanks for opening this PR. We appreciate the effort you have invested in this but we have decided not to add this feature at the minute while we decide what the feature set of the Image component should be.

In future it would be a good idea to open an issue and make a proposal before starting work.

Thanks for understanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants