-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(scraper): allow printing multiple locations #410
Conversation
(cancelled the build + deploy workflow since I didn't modify anything there) |
898dd75
to
72e8c74
Compare
Ruh roh who didn't escape their strings properly Edit: nevermind it was apparently fine the whole time. |
72e8c74
to
81c833c
Compare
81c833c
to
94aab57
Compare
Just wrapping the location line introduced a new issue that still needs to be addressed before merging: The Choose/Reset button now often gets pushed out of view, particularly in cases like MUSI1101 2023 S1 where the location is |
This comment was marked as resolved.
This comment was marked as resolved.
I've FFed 38b9326 for now so that people can at least inspect the HTML to get the full location string if they want |
94aab57
to
4cff7ce
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
I suspect this was implemented to fix cases like MUSI1101 2023 S1, is there anything else we could try? |
Relegated to rewrite. |
Fixes #409
Since we have no way of testing the scraper except in prod, @pl4nty I'd like you to take a look at this before merging.
Also, please wait for this Scrape to finish first since I want to make sure my linting changes are fineok we good