Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scraper): allow printing multiple locations #410

Closed
wants to merge 1 commit into from

Conversation

jthvai
Copy link
Collaborator

@jthvai jthvai commented Feb 20, 2024

Fixes #409

Since we have no way of testing the scraper except in prod, @pl4nty I'd like you to take a look at this before merging.

Also, please wait for this Scrape to finish first since I want to make sure my linting changes are fine ok we good

@jthvai
Copy link
Collaborator Author

jthvai commented Feb 20, 2024

(cancelled the build + deploy workflow since I didn't modify anything there)

@jthvai
Copy link
Collaborator Author

jthvai commented Feb 20, 2024

Ruh roh who didn't escape their strings properly

Edit: nevermind it was apparently fine the whole time.

@jthvai jthvai self-assigned this Feb 20, 2024
@jthvai jthvai marked this pull request as draft February 20, 2024 09:38
@jthvai
Copy link
Collaborator Author

jthvai commented Feb 20, 2024

Just wrapping the location line introduced a new issue that still needs to be addressed before merging:

The Choose/Reset button now often gets pushed out of view, particularly in cases like MUSI1101 2023 S1 where the location is "Peter Karmel 1.31; Peter Karmel Big Band Room; Peter Karmel Foster Room; Peter Karmel 1.17 Small Ensemble; Peter Karmel 1.28; Peter Karmel 1.32"

This comment was marked as resolved.

@jthvai
Copy link
Collaborator Author

jthvai commented Feb 20, 2024

I've FFed 38b9326 for now so that people can at least inspect the HTML to get the full location string if they want

@jthvai jthvai removed their assignment Mar 2, 2024

This comment was marked as outdated.

Repository owner deleted a comment from github-actions bot Mar 23, 2024
Repository owner deleted a comment from github-actions bot Mar 23, 2024
Repository owner deleted a comment from github-actions bot Mar 23, 2024

This comment was marked as outdated.

@pl4nty
Copy link
Owner

pl4nty commented Jul 20, 2024

I suspect this was implemented to fix cases like MUSI1101 2023 S1, is there anything else we could try?

@jthvai jthvai added the wontfix This will not be worked on label Jul 22, 2024
@jthvai
Copy link
Collaborator Author

jthvai commented Jul 22, 2024

Relegated to rewrite.

@jthvai jthvai closed this Jul 22, 2024
@jthvai jthvai deleted the multi-location branch July 22, 2024 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assuming events only have one location
2 participants