Add parsing of GPX extensions speed, course, hAcc, vAcc #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apple Watches track additional values that weren't being parsed these are: speed - speed in meters course - bearing hAcc - horizontal accuracy vAcc - vertical accuracy Add support for parsing and storing these values.
tmcw
reviewed
Dec 23, 2019
lib/gpx.js
Outdated
| coordinates: ll, | ||
| time: time ? nodeVal(time) : null, | ||
| heartRate: heartRate ? parseFloat(nodeVal(heartRate)) : null | ||
| }; | ||
|
|
||
| const extensions = get1(x, "extensions"); | ||
| if (extensions != null) { |
There was a problem hiding this comment.
The code is just doing a null or undefined test, it would make the test sensitive to if get1() returns undefined or null. I'd rather not be over prescriptive in case the future behavior changes. The old be generous handling with what you receive and specific with what you send.
There was a problem hiding this comment.
In this case, we aren't receiving the value from some external source - get1 is a private method that's part of togeojson and it explicitly always returns either an element or null.
There was a problem hiding this comment.
Should be all set with latest commits.
tmcw
reviewed
Dec 23, 2019
|
Thanks! Merging, quick check, then I'll roll a release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apple Watches track additional values that weren't being parsed these are:
speed - speed in meters
course - bearing
hAcc - horizontal accuracy
vAcc - vertical accuracy
Add support for parsing and storing these values.