-- Allows <Files *.psgi> Apache2 configuration, w/o specific "psgi_app" #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miyagawa
reviewed
Mar 3, 2018
| @@ -144,6 +144,8 @@ sub fixup_path { | |||
| $env->{SCRIPT_NAME} = ''; | |||
| } elsif ($path_info =~ s{^($location)/?}{/}) { | |||
| $env->{SCRIPT_NAME} = $1 || ''; | |||
| } elsif ( $r->filename() =~ /$location/) { | |||
There was a problem hiding this comment.
i think this match has a false positive.
There was a problem hiding this comment.
could be, probably begin anchor would be enough. I'll have a look at it again tomorrow.
There was a problem hiding this comment.
so, on second glance, no, it cannot have false positive. location is the regexp <Files> has and it seems a bit redundant here, because if we reach here, /$location/ will always match and will be correct. so I don't believe there is a problem here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows Apache2 to be configured as follows:
<Files ~ ".psgi$">
SetHandler perl-script
PerlResponseHandler Plack::Handler::Apache2