Fix 3.8 compatibility #26

afbora · 2022-10-06T18:52:47Z

Fix #25

index.php

lukasbestle

The changes look good to me.

plain-solutions-gmbh · 2022-10-10T16:15:52Z

Oh, the kirby core team fixed a plugin that i started. What an honor. 🤗
Thanks. 🙌
May you could take a look to this issue. It's closed but somebody is still struggling with that.
Maybe, this could be a solution: <?php /** @var \Kirby\Cms\Block $block */ ?>

afbora · 2022-10-10T16:27:37Z

You're welcome. I've also fixed that issue with this PR, here related line: https://github.com/youngcut/kirby-form-blocks/pull/26/files#diff-c380923c92306a8e0cd1507c552739451f8ac7bca3cb3882f64e7700da11a2ccR600

Fix 3.8 compatibility

15bba92

afbora mentioned this pull request Oct 6, 2022

3.8 Plugins compatibility getkirby/kirby#4713

Closed

62 tasks

lukasbestle reviewed Oct 6, 2022

View reviewed changes

index.php Show resolved Hide resolved

afbora added 2 commits October 7, 2022 00:19

Fix undefined $block variable

a4c1c94

Server to Environment

485ea35

afbora marked this pull request as draft October 6, 2022 21:21

lukasbestle approved these changes Oct 9, 2022

View reviewed changes

afbora marked this pull request as ready for review October 9, 2022 11:49

plain-solutions-gmbh merged commit f4c6ae6 into plain-solutions-gmbh:master Oct 10, 2022

afbora deleted the patch-1 branch October 10, 2022 16:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix 3.8 compatibility #26

Fix 3.8 compatibility #26

afbora commented Oct 6, 2022

lukasbestle left a comment

plain-solutions-gmbh commented Oct 10, 2022

afbora commented Oct 10, 2022 •

edited

Loading

Fix 3.8 compatibility #26

Fix 3.8 compatibility #26

Conversation

afbora commented Oct 6, 2022

lukasbestle left a comment

Choose a reason for hiding this comment

plain-solutions-gmbh commented Oct 10, 2022

afbora commented Oct 10, 2022 • edited Loading

afbora commented Oct 10, 2022 •

edited

Loading