Skip to content

Commit

Permalink
fix(bigquery): fix repr of model reference (googleapis#66)
Browse files Browse the repository at this point in the history
HemangChothani authored Mar 26, 2020

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
1 parent 2abdef8 commit 26c6204
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion google/cloud/bigquery/model.py
Original file line number Diff line number Diff line change
@@ -430,6 +430,6 @@ def __hash__(self):
return hash(self._key())

def __repr__(self):
return "ModelReference(project='{}', dataset_id='{}', project_id='{}')".format(
return "ModelReference(project_id='{}', dataset_id='{}', model_id='{}')".format(
self.project, self.dataset_id, self.model_id
)
2 changes: 1 addition & 1 deletion tests/unit/model/test_model.py
Original file line number Diff line number Diff line change
@@ -316,5 +316,5 @@ def test_repr(target_class):
got = repr(model)
assert got == (
"Model(reference=ModelReference("
"project='my-proj', dataset_id='my_dset', project_id='my_model'))"
"project_id='my-proj', dataset_id='my_dset', model_id='my_model'))"
)
2 changes: 1 addition & 1 deletion tests/unit/model/test_model_reference.py
Original file line number Diff line number Diff line change
@@ -136,5 +136,5 @@ def test_repr(target_class):
got = repr(model)
assert (
got
== "ModelReference(project='my-proj', dataset_id='my_dset', project_id='my_model')"
== "ModelReference(project_id='my-proj', dataset_id='my_dset', model_id='my_model')"
)

0 comments on commit 26c6204

Please sign in to comment.