Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New file information predicates in planck.io #863

Closed
pmonks opened this issue Feb 17, 2019 · 2 comments
Closed

New file information predicates in planck.io #863

pmonks opened this issue Feb 17, 2019 · 2 comments
Assignees
Labels
native-sdk Public SDK requiring native support

Comments

@pmonks
Copy link
Contributor

pmonks commented Feb 17, 2019

Following on from the discussion in #858 this is requesting the addition of the following predicates to the planck.io namespace:

@pmonks
Copy link
Contributor Author

pmonks commented Feb 17, 2019

Note: I am working on some of this as we speak, but am unable to assign the issue to myself - @mfikes please feel free to assign it to me.

mfikes pushed a commit that referenced this issue Feb 24, 2019
…es to planck.io (#864)

* 🆕 Adds exists?, regular-file? and symbolic-link? predicates to planck.io namespace (issue #863)

* 📚 Adds docs for new fns in planck.io ns

* 📚 Add PR #864 changes to CHANGELOG

* 🚑 Remove type hints, as requested in review of PR #864

* ☔ Add tests for fns added in PR #864

* 🚑 Comment out tests that are unreliable across platforms

* 🚑 Make changelog entry format consistent

* ☔ Fix tests for regular files and directories

* 🆕 Adds hidden-file? fn to planck.io

* 🆕 Make path-elements and file-name public, based on PR feedback

* 🚑 Re-apply updated docstring to markdown docs

* 🚑 Remove warning regarding exists? in planck.io

* 🚑 Restore spurious whitespace

* 🚑 Restore spurious whitespace

* 🚑 Bring published doc inline with docstring

* 🚑 Improves implementation consistency

* 🚑 Update predicates based on review feedback
@pmonks
Copy link
Contributor Author

pmonks commented Feb 24, 2019

I believe this is fixed in rev 0071f60.

@mfikes mfikes closed this as completed Feb 24, 2019
@mfikes mfikes added the native-sdk Public SDK requiring native support label May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
native-sdk Public SDK requiring native support
Projects
None yet
Development

No branches or pull requests

2 participants