restore Summon.HasNotification #6484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonohoshi
requested review from
tyrosine1153,
jonny-jeahyunchoi and
eugene-doobu
as code owners
|
@sonohoshi The versions of bundled Libplanet assemblies and Libplanet submodule vendored by Lib9c apparently do not match:
Leave a comment in this pull_request with the following command to let the bot upgrade bundled Libplanet assemblies:
|
| { | ||
| var costType = (CostType)summonRow.CostMaterial; | ||
| var cost = summonRow.CostMaterialCount; | ||
| result |= SimpleCostButton.CheckCostOfType(costType, cost); |
There was a problem hiding this comment.
그러네요 괜히 순회 더 하는것보다 그게 나을듯?
There was a problem hiding this comment.
@eugene-doobu Any 쓰게 바꿨습니다. 알아서 linq가 최적화 해주겠거니...
eugene-doobu
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Links
resolve #6370
Screenshot