Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/synthesize #6537

Merged
merged 29 commits into from
Dec 5, 2024
Merged

Feature/synthesize #6537

merged 29 commits into from
Dec 5, 2024

Conversation

eugene-doobu
Copy link
Member

Synthesis 관련 UI 기반 작업입니다.

아직 모든 작업이 완료된건 아니며 다음 작업은 아래 이슈로 Synthesis 클래스의 OnClickGradeItem 구현을 채워놓는 것으로 시작 할 예정입니다. 해당 작업을 포함하여 기본 작업에서 추가 작업이 필요한 부분은 TODO 코멘트 달아두었습니다.

#6502

…size

# Conflicts:
#	nekoyume/Assets/_Scripts/Lib9c/lib9c
…size

# Conflicts:
#	nekoyume/Assets/_Scripts/Lib9c/lib9c
@eugene-doobu eugene-doobu linked an issue Dec 3, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Dec 3, 2024

@eugene-doobu The versions of bundled Libplanet assemblies and Libplanet submodule vendored by Lib9c apparently do not match:

  • Libplanet submdoule:
  • Libplanet.Action.dll: 5.4.0
  • Libplanet.Common.dll: 5.4.0
  • Libplanet.Crypto.dll: 5.4.0
  • Libplanet.Mocks.dll: 5.4.0
  • Libplanet.RocksDBStore.dll: 5.4.0
  • Libplanet.Store.dll: 5.4.0
  • Libplanet.Types.dll: 5.4.0
  • Libplanet.dll: 5.4.0

Leave a comment in this pull_request with the following command to let the bot upgrade bundled Libplanet assemblies:

/update-libplanet-dlls

@eugene-doobu eugene-doobu added this to the v260.0.0 milestone Dec 3, 2024
@eugene-doobu eugene-doobu linked an issue Dec 3, 2024 that may be closed by this pull request
@eugene-doobu eugene-doobu removed a link to an issue Dec 3, 2024
@eugene-doobu
Copy link
Member Author

ai 코드리뷰, 해당 리뷰 내용은 별도 이슈에서 처리하겠습니다
https://planetariumhq.slack.com/archives/C072TSDKQPM/p1733206578984129

@eugene-doobu eugene-doobu merged commit cf1bdf1 into development Dec 5, 2024
2 checks passed
@eugene-doobu eugene-doobu deleted the feature/synthesize branch December 5, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

합성 기본 로직 UI 연결
1 participant