Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/synthesis polishing #6846

Merged
merged 2 commits into from
Feb 10, 2025
Merged

Conversation

eugene-doobu
Copy link
Member

This pull request includes several changes to improve the synthesis functionality and UI interactions in the nekoyume project. The most important changes include adding equality operators to the SynthesizeModel class, refactoring the SynthesisInventory class, and enhancing the SynthesisRegistrationPopup class to handle model updates and clear actions more effectively.

Improvements to SynthesizeModel class:

  • Added == and != operators to the SynthesizeModel class to allow for easy comparison of instances based on Grade and ItemSubType.

Refactoring of SynthesisInventory class:

  • Removed the _disposables list and refactored the OnEnable and OnDisable methods to update the inventory directly. [1] [2]

Enhancements to SynthesisRegistrationPopup class:

  • Added a HasModel method to check if the popup currently holds a specific model.
  • Modified the Show method to check for the same model and update the inventory if necessary. [1] [2]
  • Added a Clear method to reset the registration state and update the inventory.
  • Improved the ShowItemTooltip method to handle active tooltips more gracefully.

Other UI updates:

  • Updated the Synthesis class to use the new HasModel method in the OnClickGradeItem method to prevent redundant popup displays.
  • Added a call to clear the SynthesisRegistrationPopup in the ClearScrollData method of the SynthesisModule class.

@eugene-doobu eugene-doobu self-assigned this Feb 10, 2025
@github-actions github-actions bot added this to the v280.0.0 milestone Feb 10, 2025
@eugene-doobu eugene-doobu merged commit c60ab3f into prepare/280.0.x Feb 10, 2025
16 checks passed
@eugene-doobu eugene-doobu deleted the feature/synthesis-polishing branch February 12, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[워크샵] 합성 재료 등록 후 다시 재료 추가 시 기존 등록 재료가 해제되는 현상
1 participant