Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to improve the synthesis functionality and UI interactions in the
nekoyume
project. The most important changes include adding equality operators to theSynthesizeModel
class, refactoring theSynthesisInventory
class, and enhancing theSynthesisRegistrationPopup
class to handle model updates and clear actions more effectively.Improvements to
SynthesizeModel
class:==
and!=
operators to theSynthesizeModel
class to allow for easy comparison of instances based onGrade
andItemSubType
.Refactoring of
SynthesisInventory
class:_disposables
list and refactored theOnEnable
andOnDisable
methods to update the inventory directly. [1] [2]Enhancements to
SynthesisRegistrationPopup
class:HasModel
method to check if the popup currently holds a specific model.Show
method to check for the same model and update the inventory if necessary. [1] [2]Clear
method to reset the registration state and update the inventory.ShowItemTooltip
method to handle active tooltips more gracefully.Other UI updates:
Synthesis
class to use the newHasModel
method in theOnClickGradeItem
method to prevent redundant popup displays.SynthesisRegistrationPopup
in theClearScrollData
method of theSynthesisModule
class.