Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mining should stopped when the chain's tip is changed #460

Closed
longfin opened this issue Aug 26, 2019 · 0 comments · Fixed by #517
Closed

Mining should stopped when the chain's tip is changed #460

longfin opened this issue Aug 26, 2019 · 0 comments · Fixed by #517
Assignees
@limebell

Comments

@longfin
Copy link
Member

longfin commented Aug 26, 2019

The current BlockChain<T>.MineBlock() doesn't stop mining when the chain's tip was changed by accepting a block from other miners. at this time, the mined block has the same index as a received block, so it always will fail to append.

To prevent this scenario, BlockChain<T>.MineBlock() should stop when its tip was changed.
@longfin longfin changed the title Stop mining when the chains' tip was changed Stop mining when the chain's tip was changed Aug 26, 2019
@dahlia dahlia changed the title Stop mining when the chain's tip was changed Mining should stopped when the chain's tip is changed Aug 27, 2019
@limebell limebell self-assigned this Sep 17, 2019
@limebell limebell mentioned this issue Sep 19, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@limebell limebell

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cancel mining if blockchain's tip index is changed limebell/libplanet
2 participants
@longfin @limebell