Cancel mining if blockchain's tip index is changed #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
limebell
force-pushed
the
mine-cancel
branch
from
fed45f1 to
88496db
Compare
limebell
changed the title
limebell
force-pushed
the
mine-cancel
branch
from
88496db to
e277dab
Compare
|
Tests in several environments failed due to timeout. |
limebell
force-pushed
the
mine-cancel
branch
3 times, most recently
from
54d44a1 to
512f5bf
Compare
Codecov Report
@@ Coverage Diff @@
## master #517 +/- ##
==========================================
+ Coverage 90.3% 90.32% +0.02%
==========================================
Files 201 201
Lines 14928 15013 +85
==========================================
+ Hits 13481 13561 +80
- Misses 1170 1174 +4
- Partials 277 278 +1
|
dahlia
reviewed
Sep 19, 2019
earlbread
reviewed
Sep 19, 2019
| Assert.Throws<InvalidBlockIndexException>(() => _blockChain.Append(block)); | ||
| Assert.False(called); | ||
|
|
||
| // TODO: Add test cases for swap |
There was a problem hiding this comment.
It would be good to have an issue for this.
dahlia
reviewed
Sep 20, 2019
limebell
force-pushed
the
mine-cancel
branch
from
512f5bf to
afa139d
Compare
limebell
force-pushed
the
mine-cancel
branch
from
afa139d to
9494bee
Compare
limebell
requested review from
libplanet and
a team
and removed request for
libplanet
limebell
force-pushed
the
mine-cancel
branch
3 times, most recently
from
c48869d to
5184241
Compare
dahlia
suggested changes
Sep 23, 2019
longfin
reviewed
Sep 23, 2019
Libplanet/Blockchain/BlockChain.cs
Outdated
| throw new OperationCanceledException( | ||
| "Mining canceled due to change of tip index"); | ||
| } | ||
| else |
There was a problem hiding this comment.
How about just re-throw it?
Suggested change
| else | |
| throw; |
There was a problem hiding this comment.
I used TaskCanceledException here because other tasks used in Swarm<T> throw TaskCanceledException when cancel is requested.
limebell
force-pushed
the
mine-cancel
branch
from
5184241 to
838655e
Compare
limebell
force-pushed
the
mine-cancel
branch
from
838655e to
bf8de58
Compare
earlbread
approved these changes
Sep 23, 2019
longfin
approved these changes
Sep 23, 2019
dahlia
approved these changes
Sep 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch implements and closes #460. Some XML descriptions and test cases are included in this PR.