Combine creating and staging transaction interface #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
earlbread
force-pushed
the
fix-transaction-interface
branch
2 times, most recently
from
7757ab6 to
92b9453
Compare
Codecov Report
@@ Coverage Diff @@
## master #294 +/- ##
==========================================
+ Coverage 87.38% 87.44% +0.05%
==========================================
Files 186 186
Lines 12449 12502 +53
==========================================
+ Hits 10879 10932 +53
+ Misses 1323 1321 -2
- Partials 247 249 +2
|
longfin
reviewed
Jun 18, 2019
earlbread
force-pushed
the
fix-transaction-interface
branch
from
92b9453 to
4ef0cad
Compare
longfin
previously approved these changes
Jun 18, 2019
dahlia
reviewed
Jun 19, 2019
Libplanet/Tx/Transaction.cs
Outdated
| actionsArray, | ||
| sig | ||
| ); | ||
| } |
There was a problem hiding this comment.
Does this method have to be removed at all? I thought this is fine to remain, and BlockChain<T>.MakeTransaction() method could be a thin façade on this.
There was a problem hiding this comment.
I think it's okay to leave this, but is there a use case?
earlbread
force-pushed
the
fix-transaction-interface
branch
2 times, most recently
from
5b407b3 to
ad0a9b8
Compare
earlbread
force-pushed
the
fix-transaction-interface
branch
from
ad0a9b8 to
03a4753
Compare
|
I made |
dahlia
approved these changes
Jun 20, 2019
longfin
approved these changes
Jun 20, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BlockChain<T>.MakeTransaction()method.