Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dispose _turnClient properly #450

Merged
merged 3 commits into from
Aug 26, 2019
Merged

Conversation

longfin
Copy link
Member

@longfin longfin commented Aug 21, 2019

This PR ensures resource disposing of resources in Swarm<T>.

@longfin longfin marked this pull request as ready for review August 21, 2019 07:54
earlbread
earlbread previously approved these changes Aug 21, 2019
CHANGES.md Outdated Show resolved Hide resolved
moreal
moreal previously approved these changes Aug 21, 2019
@longfin longfin dismissed stale reviews from moreal and earlbread via 2ca92ec August 21, 2019 08:02
CHANGES.md Outdated Show resolved Hide resolved
limebell
limebell previously approved these changes Aug 21, 2019
earlbread
earlbread previously approved these changes Aug 21, 2019
dahlia
dahlia previously approved these changes Aug 21, 2019
@longfin longfin dismissed stale reviews from dahlia and earlbread via f745135 August 21, 2019 13:19
@longfin
Copy link
Member Author

longfin commented Aug 21, 2019

I've rebased. PTAL.

earlbread
earlbread previously approved these changes Aug 21, 2019
@longfin longfin added this to the 0.6.0 milestone Aug 22, 2019
@longfin
Copy link
Member Author

longfin commented Aug 23, 2019

I've rebased to append it to 0.6.0.

@longfin longfin requested review from dahlia, limebell and moreal August 26, 2019 04:45
@longfin longfin merged commit a079b95 into planetarium:master Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants