-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dispose _turnClient properly #450
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
earlbread
previously approved these changes
Aug 21, 2019
dahlia
reviewed
Aug 21, 2019
moreal
previously approved these changes
Aug 21, 2019
longfin
force-pushed
the
bugfix/dispose
branch
from
August 21, 2019 08:02
7442212
to
2ca92ec
Compare
earlbread
reviewed
Aug 21, 2019
limebell
previously approved these changes
Aug 21, 2019
longfin
force-pushed
the
bugfix/dispose
branch
from
August 21, 2019 08:23
2ca92ec
to
c7bc6c5
Compare
earlbread
previously approved these changes
Aug 21, 2019
dahlia
previously approved these changes
Aug 21, 2019
longfin
force-pushed
the
bugfix/dispose
branch
from
August 21, 2019 13:19
c7bc6c5
to
f745135
Compare
I've rebased. PTAL. |
earlbread
previously approved these changes
Aug 21, 2019
longfin
force-pushed
the
bugfix/dispose
branch
from
August 23, 2019 05:29
f745135
to
f1b321a
Compare
I've rebased to append it to 0.6.0. |
earlbread
approved these changes
Aug 23, 2019
moreal
approved these changes
Aug 26, 2019
limebell
approved these changes
Aug 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures resource disposing of resources in
Swarm<T>
.