Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broadcast transaction as soon as new transactions received #496

Merged
merged 3 commits into from
Sep 4, 2019
Merged

Broadcast transaction as soon as new transactions received #496

merged 3 commits into from
Sep 4, 2019

Conversation

limebell
Copy link
Member

@limebell limebell commented Sep 4, 2019

This PR resolves #463.

@limebell limebell self-assigned this Sep 4, 2019
longfin
longfin requested changes Sep 4, 2019
View reviewed changes
CHANGES.md Outdated Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
@limebell limebell force-pushed the fix-463 branch 2 times, most recently from 83d9551 to 5d31b9f Compare September 4, 2019 06:32
@limebell limebell added this to the 0.6.0 milestone Sep 4, 2019
longfin
longfin previously approved these changes Sep 4, 2019
View reviewed changes
moreal
moreal suggested changes Sep 4, 2019
View reviewed changes
CHANGES.md Outdated Show resolved Hide resolved
moreal
moreal previously approved these changes Sep 4, 2019
View reviewed changes
earlbread
earlbread previously approved these changes Sep 4, 2019
View reviewed changes
@codecov
Copy link

codecov bot commented Sep 4, 2019 •
edited
Loading

Codecov Report

Merging #496 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #496      +/-   ##
==========================================
- Coverage   89.96%   89.93%   -0.04%     
==========================================
  Files         200      200              
  Lines       14506    14506              
==========================================
- Hits        13051    13046       -5     
- Misses       1178     1183       +5     
  Partials      277      277
Impacted Files Coverage Δ
Libplanet/Net/Swarm.cs 81.29% <100%> (-0.14%) ⬇️
Libplanet/Net/Protocols/KademliaProtocol.cs 60.23% <0%> (-0.88%) ⬇️

@limebell limebell dismissed stale reviews from earlbread and moreal via 9668bd1 September 4, 2019 08:42
dahlia
dahlia previously approved these changes Sep 4, 2019
View reviewed changes
earlbread
earlbread previously approved these changes Sep 4, 2019
View reviewed changes
@limebell limebell dismissed stale reviews from earlbread and dahlia via 037f6db September 4, 2019 09:22
longfin
longfin previously approved these changes Sep 4, 2019
View reviewed changes
@limebell
Copy link
Member Author

limebell commented Sep 4, 2019

Actually AppendBlocksAsync should not call BroadcastBlocks, but currently there's no appropriate place for this so it's temporary in there.

@longfin longfin merged commit 7d66d36 into planetarium:master Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moreal moreal moreal approved these changes

@earlbread earlbread earlbread approved these changes

@dahlia dahlia dahlia approved these changes

@longfin longfin longfin left review comments

Assignees

@limebell limebell

Labels
None yet
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.

Broadcast transaction when a transaction is staged
5 participants
@limebell @dahlia @longfin @earlbread @moreal