Fix Swarm<T>.PreloadAsync() missing genesis states #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longfin
previously approved these changes
Sep 12, 2019
limebell
previously approved these changes
Sep 12, 2019
moreal
previously approved these changes
Sep 12, 2019
Codecov Report
@@ Coverage Diff @@
## master #512 +/- ##
==========================================
+ Coverage 90.07% 90.12% +0.05%
==========================================
Files 201 201
Lines 14718 14791 +73
==========================================
+ Hits 13257 13331 +74
+ Misses 1177 1176 -1
Partials 284 284
|
earlbread
previously approved these changes
Sep 16, 2019
longfin
reviewed
Sep 17, 2019
The bug was made at 6e7249f. [changelog skip]
dahlia
force-pushed
the
fix-preload-missing-genesis-states
branch
from
b4820e2 to
083024e
Compare
|
@planetarium/libplanet Adjusted the changelog. Please approve this again. |
earlbread
approved these changes
Sep 17, 2019
moreal
approved these changes
Sep 17, 2019
longfin
approved these changes
Sep 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes a bug, made by 6e7249f, that
Swarm<T>.PreloadAsync()silently misses the states resulted from actins in a genesis block (both tx actions and block actions) when it downloads states from trusted peers.As the change made this bug hasn't been released yet, I skipped the changelog.