Demand block hashes from branch point #905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 0.9-maintenance #905 +/- ##
===================================================
+ Coverage 87.66% 87.68% +0.02%
===================================================
Files 251 251
Lines 22767 22808 +41
===================================================
+ Hits 19958 20000 +42
Misses 1463 1463
+ Partials 1346 1345 -1
|
moreal
reviewed
Jun 11, 2020
riemannulus
reviewed
Jun 11, 2020
earlbread
force-pushed
the
fix-demand-block-hashes
branch
from
d4b3117 to
38797fa
Compare
longfin
reviewed
Jun 12, 2020
earlbread
force-pushed
the
fix-demand-block-hashes
branch
from
38797fa to
afcc6e5
Compare
longfin
previously approved these changes
Jun 12, 2020
riemannulus
previously approved these changes
Jun 12, 2020
dahlia
previously approved these changes
Jun 12, 2020
Co-authored-by: Hong Minhee (洪 民憙) <hong.minhee@gmail.com>
earlbread
dismissed stale reviews from dahlia, riemannulus, and longfin
via
bc6a641
longfin
approved these changes
Jun 12, 2020
riemannulus
approved these changes
Jun 12, 2020
moreal
approved these changes
Jun 12, 2020
dahlia
approved these changes
Jun 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug that did not properly receive block hashes after the chain has reorged.