Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use named tuple in method signature #517

Merged
merged 2 commits into from
Nov 23, 2024
Merged

use named tuple in method signature #517

merged 2 commits into from
Nov 23, 2024

Conversation

Mecit-SA
Copy link
Contributor

@Mecit-SA Mecit-SA commented Nov 22, 2024 •
edited
Loading

Resolves #482

@CLAassistant
Copy link

CLAassistant commented Nov 22, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

moreal
moreal approved these changes Nov 23, 2024
View reviewed changes
Copy link
Contributor

@moreal moreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😀

@moreal
Copy link
Contributor

moreal commented Nov 23, 2024

Thank you for your contribution!

@moreal moreal added this pull request to the merge queue Nov 23, 2024
Merged via the queue into planetarium:main with commit 4053ccd Nov 23, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moreal moreal moreal approved these changes

@boscohyun boscohyun boscohyun approved these changes

@Atralupus Atralupus Awaiting requested review from Atralupus

Assignees

@Mecit-SA Mecit-SA

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor: make return type of BaseDiffHandler.CalculateCurrentAndTargetIndexes understandable
4 participants
@Mecit-SA @CLAassistant @moreal @boscohyun