PDX-356: Move POST DP API to GET /arena/rankings API #8

XxshiftxX · 2024-02-22T09:59:04Z

No description provided.

pull-request-quantifier-deprecated · 2024-02-22T10:00:58Z

This PR has 53 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details

Label      : Small
Size       : +51 -2
Percentile : 21.2%

Total files changed: 8

Change summary by file extension:
.gitignore : +1 -0
.cs : +49 -2
.csproj : +1 -0

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

Fast and predictable releases to production:
- Optimal size changes are more likely to be reviewed faster with fewer
  iterations.
- Similarity in low PR complexity drives similar review times.
Review quality is likely higher as complexity is lower:
- Bugs are more likely to be detected.
- Code inconsistencies are more likely to be detected.
Knowledge sharing is improved within the participants:
- Small portions can be assimilated better.
Better engineering practices are exercised:
- Solving big problems by dividing them in well contained, smaller problems.
- Exercising separation of concerns within the code changes.

What can I do to optimize my changes

Use the PullRequestQuantifier to quantify your PR accurately
- Create a context profile for your repo using the context generator
- Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
- Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
- Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
Change your engineering behaviors
- For PRs that fall outside of the desired spectrum, review the details and check if:
  - Your PR could be split in smaller, self-contained PRs instead
  - Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

One line was added: +1 -0
One line was deleted: +0 -1
One line was modified: +1 -1 (git diff doesn't know about modified, it will
interpret that line like one addition plus one deletion)
Change percentiles: Change characteristics (addition, deletion, modification)
of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

pull-request-quantifier-deprecated · 2024-02-23T00:27:19Z

This PR has 89 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details

Label      : Small
Size       : +87 -2
Percentile : 35.6%

Total files changed: 8

Change summary by file extension:
.gitignore : +1 -0
.cs : +85 -2
.csproj : +1 -0

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

Fast and predictable releases to production:
- Optimal size changes are more likely to be reviewed faster with fewer
  iterations.
- Similarity in low PR complexity drives similar review times.
Review quality is likely higher as complexity is lower:
- Bugs are more likely to be detected.
- Code inconsistencies are more likely to be detected.
Knowledge sharing is improved within the participants:
- Small portions can be assimilated better.
Better engineering practices are exercised:
- Solving big problems by dividing them in well contained, smaller problems.
- Exercising separation of concerns within the code changes.

What can I do to optimize my changes

Use the PullRequestQuantifier to quantify your PR accurately
- Create a context profile for your repo using the context generator
- Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
- Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
- Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
Change your engineering behaviors
- For PRs that fall outside of the desired spectrum, review the details and check if:
  - Your PR could be split in smaller, self-contained PRs instead
  - Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

One line was added: +1 -0
One line was deleted: +0 -1
One line was modified: +1 -1 (git diff doesn't know about modified, it will
interpret that line like one addition plus one deletion)
Change percentiles: Change characteristics (addition, deletion, modification)
of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

pull-request-quantifier-deprecated · 2024-02-23T01:21:06Z

This PR has 101 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details

Label      : Medium
Size       : +99 -2
Percentile : 40.2%

Total files changed: 8

Change summary by file extension:
.gitignore : +1 -0
.cs : +97 -2
.csproj : +1 -0

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

Fast and predictable releases to production:
- Optimal size changes are more likely to be reviewed faster with fewer
  iterations.
- Similarity in low PR complexity drives similar review times.
Review quality is likely higher as complexity is lower:
- Bugs are more likely to be detected.
- Code inconsistencies are more likely to be detected.
Knowledge sharing is improved within the participants:
- Small portions can be assimilated better.
Better engineering practices are exercised:
- Solving big problems by dividing them in well contained, smaller problems.
- Exercising separation of concerns within the code changes.

What can I do to optimize my changes

Use the PullRequestQuantifier to quantify your PR accurately
- Create a context profile for your repo using the context generator
- Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
- Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
- Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
Change your engineering behaviors
- For PRs that fall outside of the desired spectrum, review the details and check if:
  - Your PR could be split in smaller, self-contained PRs instead
  - Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

One line was added: +1 -0
One line was deleted: +0 -1
One line was modified: +1 -1 (git diff doesn't know about modified, it will
interpret that line like one addition plus one deletion)
Change percentiles: Change characteristics (addition, deletion, modification)
of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

moreal · 2024-02-26T08:07:56Z

NineChroniclesUtilBackend/Services/MongoDBCollectionService.cs

+        var database = client.GetDatabase(_databaseOption.Value.DatabaseName);
+        return database.GetCollection<T>(collectionName);
+    }
+}


Please insert newline at the EOFs.

pull-request-quantifier-deprecated · 2024-02-29T02:01:01Z

This PR has 274 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details

Label      : Large
Size       : +255 -19
Percentile : 67.4%

Total files changed: 10

Change summary by file extension:
.gitignore : +1 -0
.cs : +253 -19
.csproj : +1 -0

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

Fast and predictable releases to production:
- Optimal size changes are more likely to be reviewed faster with fewer
  iterations.
- Similarity in low PR complexity drives similar review times.
Review quality is likely higher as complexity is lower:
- Bugs are more likely to be detected.
- Code inconsistencies are more likely to be detected.
Knowledge sharing is improved within the participants:
- Small portions can be assimilated better.
Better engineering practices are exercised:
- Solving big problems by dividing them in well contained, smaller problems.
- Exercising separation of concerns within the code changes.

What can I do to optimize my changes

Use the PullRequestQuantifier to quantify your PR accurately
- Create a context profile for your repo using the context generator
- Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
- Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
- Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
Change your engineering behaviors
- For PRs that fall outside of the desired spectrum, review the details and check if:
  - Your PR could be split in smaller, self-contained PRs instead
  - Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

One line was added: +1 -0
One line was deleted: +0 -1
One line was modified: +1 -1 (git diff doesn't know about modified, it will
interpret that line like one addition plus one deletion)
Change percentiles: Change characteristics (addition, deletion, modification)
of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

pull-request-quantifier-deprecated · 2024-02-29T02:01:41Z

This PR has 274 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details

Label      : Large
Size       : +255 -19
Percentile : 67.4%

Total files changed: 10

Change summary by file extension:
.gitignore : +1 -0
.cs : +253 -19
.csproj : +1 -0

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

Fast and predictable releases to production:
- Optimal size changes are more likely to be reviewed faster with fewer
  iterations.
- Similarity in low PR complexity drives similar review times.
Review quality is likely higher as complexity is lower:
- Bugs are more likely to be detected.
- Code inconsistencies are more likely to be detected.
Knowledge sharing is improved within the participants:
- Small portions can be assimilated better.
Better engineering practices are exercised:
- Solving big problems by dividing them in well contained, smaller problems.
- Exercising separation of concerns within the code changes.

What can I do to optimize my changes

Use the PullRequestQuantifier to quantify your PR accurately
- Create a context profile for your repo using the context generator
- Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
- Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
- Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
Change your engineering behaviors
- For PRs that fall outside of the desired spectrum, review the details and check if:
  - Your PR could be split in smaller, self-contained PRs instead
  - Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

One line was added: +1 -0
One line was deleted: +0 -1
One line was modified: +1 -1 (git diff doesn't know about modified, it will
interpret that line like one addition plus one deletion)
Change percentiles: Change characteristics (addition, deletion, modification)
of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

moreal · 2024-02-29T03:34:55Z

NineChroniclesUtilBackend/Repositories/CpRepository.cs

+            .Where(x => x != null)
+            .Select(x => new Costume(x))
+            .Where(x => x.Equipped);
+        var runes = runeOption.Select(x => GetRuneOptionInfo(x.id, x.level).Result);


Suggested change

var runes = runeOption.Select(x => GetRuneOptionInfo(x.id, x.level).Result);

var runes = await Task.WhenAll(runeOption.Select(x => GetRuneOptionInfo(x.id, x.level)));

moreal · 2024-02-29T03:42:07Z

NineChroniclesUtilBackend/Models/Arena/ArenaRanking.cs

+
+namespace NineChroniclesUtilBackend.Models.Arena;
+
+public class ArenaRanking(


It seems like a case to use record type. (maybe)

At first, I thought adding cp calculation part to getter (or static method) of ArenaRanking or Avatar. Because it's kind of (Domain) Entity and cp calculation code is domain logic. I will apply these refactor on following Pull Request and ticket.

XxshiftxX added 4 commits February 22, 2024 17:40

Add local appsettings to .gitignore

855de0d

Add MongoDB.Driver

f8cf7f2

Add DatabaseOption

b458232

Add sample mongodb query for GET /arena/ranking API

d06afcd

XxshiftxX self-assigned this Feb 22, 2024

pull-request-quantifier-deprecated bot added the Small label Feb 22, 2024

Fix dynamic to ArenaRanking

c0ab058

Add base offset for avatarAddress query

9578aa1

pull-request-quantifier-deprecated bot removed the Small label Feb 23, 2024

pull-request-quantifier-deprecated bot added the Medium label Feb 23, 2024

XxshiftxX marked this pull request as ready for review February 23, 2024 01:21

XxshiftxX requested review from Atralupus and moreal and removed request for Atralupus February 23, 2024 01:21

XxshiftxX changed the title ~~[WIP] PDX-356: Move POST DP API to GET /arena/rankings API~~ PDX-356: Move POST DP API to GET /arena/rankings API Feb 23, 2024

moreal reviewed Feb 28, 2024

View reviewed changes

Add cp calculation on arena info API

a582e06

pull-request-quantifier-deprecated bot added Large and removed Medium labels Feb 29, 2024

Add EOF newline

d89e216

XxshiftxX requested a review from moreal February 29, 2024 02:01

moreal approved these changes Feb 29, 2024

View reviewed changes

XxshiftxX merged commit 39b5bc9 into main Feb 29, 2024
2 checks passed

XxshiftxX deleted the PDX-356 branch February 29, 2024 04:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PDX-356: Move POST DP API to GET /arena/rankings API #8

PDX-356: Move POST DP API to GET /arena/rankings API #8

XxshiftxX commented Feb 22, 2024

pull-request-quantifier-deprecated bot commented Feb 22, 2024

What can I do to optimize my changes

How to interpret the change counts in git diff output

pull-request-quantifier-deprecated bot commented Feb 23, 2024

What can I do to optimize my changes

How to interpret the change counts in git diff output

pull-request-quantifier-deprecated bot commented Feb 23, 2024

What can I do to optimize my changes

How to interpret the change counts in git diff output

moreal Feb 26, 2024

pull-request-quantifier-deprecated bot commented Feb 29, 2024

What can I do to optimize my changes

How to interpret the change counts in git diff output

pull-request-quantifier-deprecated bot commented Feb 29, 2024

What can I do to optimize my changes

How to interpret the change counts in git diff output

moreal Feb 29, 2024

moreal Feb 29, 2024

XxshiftxX Feb 29, 2024

	var runes = runeOption.Select(x => GetRuneOptionInfo(x.id, x.level).Result);
	var runes = await Task.WhenAll(runeOption.Select(x => GetRuneOptionInfo(x.id, x.level)));


		namespace NineChroniclesUtilBackend.Models.Arena;

		public class ArenaRanking(

PDX-356: Move POST DP API to GET /arena/rankings API #8

PDX-356: Move POST DP API to GET /arena/rankings API #8

Conversation

XxshiftxX commented Feb 22, 2024

pull-request-quantifier-deprecated bot commented Feb 22, 2024

What can I do to optimize my changes

How to interpret the change counts in git diff output

pull-request-quantifier-deprecated bot commented Feb 23, 2024

What can I do to optimize my changes

How to interpret the change counts in git diff output

pull-request-quantifier-deprecated bot commented Feb 23, 2024

What can I do to optimize my changes

How to interpret the change counts in git diff output

moreal Feb 26, 2024

Choose a reason for hiding this comment

pull-request-quantifier-deprecated bot commented Feb 29, 2024

What can I do to optimize my changes

How to interpret the change counts in git diff output

pull-request-quantifier-deprecated bot commented Feb 29, 2024

What can I do to optimize my changes

How to interpret the change counts in git diff output

moreal Feb 29, 2024

Choose a reason for hiding this comment

moreal Feb 29, 2024

Choose a reason for hiding this comment

XxshiftxX Feb 29, 2024

Choose a reason for hiding this comment