Add NITF Raster Support #39
Conversation
Remove unnecessary mutable default value as arg minor line-length fixes for readability test name change -- geotiff is not all rasters
Remove GeoTIFF-only metadata property check, add universal check for
vector vs raster data type
GetMetaDataItem('AREA_OR_POINT') is only guaranteed to exist on GeoTIFF
files; a check for this property on e.g., NITF files will fail
|
Clean PR, code's pretty clean, code doesn't look like it should break anything, doesn't seem to break anything in practice, and NITF upload works for me. 👍 when CI passes (and I know we have had recent CI problems and CI won't pass until the test data is in the S3 bucket). |
|
I will be uploading the data to the test bucket here pretty quick. You can On Friday, October 28, 2016, Sasha Hart notifications@github.com wrote:
|
ghost
mentioned this pull request
|
Closing due to repo move. GeoNode#47 |
ghost
closed this
ghost
mentioned this pull request
Previously, osgeo-importer assumed all rasters were GeoTIFFs; a check for a tiff-specific metadata property was the "is this a raster?" gatekeeper. This caused import of rasters without that property (e.g., NITF) to fail. With this change, all rasters with a supported driver in the environment's GDAL installation can be imported.
As the NITF driver is compiled by default in GDAL installations, it's present in all our environments and safe to add to the default extensions whitelist here. Custom environments with additional non-default drivers like JPEG2000 can add extensions to the whitelist in their own settings.
Note this will fail CI until the new NITF test file is added to the S3 bucket; request for that is pending