Skip to content

Conversation

mmidzik
Copy link
Collaborator

@mmidzik mmidzik commented Jan 22, 2024

This is a bit new to me, but currently, the go.mod file uses 1.21.0, pinning to a patch rather than a minor version. I believe this in turn requires all dependent code to specify a patch version (I found this issue because my go mod tidy in dependent repos was adding a patch to the semver).

Specifying only the major and minor version can offer broader compatibility with different patch versions, and I think is OK here.

Copy link
Member

@tschaub tschaub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mmidzik

@mmidzik mmidzik merged commit a564f71 into main Jan 22, 2024
@mmidzik mmidzik deleted the mm/pin_to_1.21 branch January 22, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants