validator: return validation error for extension validation errors #188
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When validating schema extensions the validator result isn't very helpful. Here is an example error:
It would be useful to receive the report for the entire validation, especially the failed resource. With this change we should see the full validation result - example:
This is accomplished by ensuring that the extension error is actually a
jsonschema.ValidationError
and then pass this to thenewValidationError
func to preserve context.If for some reason we can't parse the error as expected, we go ahead and return it as usual.