Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hosting Block Convenience Method to SDK #1029

Merged
merged 18 commits into from
Apr 4, 2024
Merged

Add Hosting Block Convenience Method to SDK #1029

merged 18 commits into from
Apr 4, 2024

Conversation

emma-steuer
Copy link
Contributor

@emma-steuer emma-steuer commented Mar 26, 2024

Related Issue(s):

Closes #

Proposed Changes:

For inclusion in changelog (if applicable):

  1. Support Subscriptions API hosting block for Sentinel Hub in the CLI (Add Hosting Block Convenience Method to SDK #1029).

Not intended for changelog:

  1. N/A

Diff of User Interface

Old behavior: Hosting was not supported for create and request for the Subscriptions CLI.

New behavior: Hosting is now supported for both create and request in the Subscriptions CLI. --hosting and --collection_id are flags used for this.

PR Checklist:

  • This PR is as small and focused as possible
  • If this PR includes proposed changes for inclusion in the changelog, the title of this PR summarizes those changes and is ready for inclusion in the Changelog.
  • I have updated docstrings for function changes and docs in the 'docs' folder for user interface / behavior changes
  • This PR does not break any examples or I have updated them

(Optional) @mentions for Notifications:

@asonnenschein
Copy link
Contributor

Following up re: other places in the CLI where the hosting flags could be added --

The CLI has convenience methods that structure JSON payloads from flagged arguments (see https://planet-sdk-for-python-v2.readthedocs.io/en/latest/cli/cli-subscriptions/#subscription-request-conveniences). JSON output from these commands can be piped into the subscriptions create command. With that in mind, I think convenience method request (https://github.com/planetlabs/planet-client-python/blob/main/planet/cli/subscriptions.py#L274) should be enhanced with hosting flag arguments similar to the create command.

@emma-steuer emma-steuer self-assigned this Apr 3, 2024
planet/cli/subscriptions.py Show resolved Hide resolved
planet/cli/subscriptions.py Outdated Show resolved Hide resolved
planet/cli/subscriptions.py Outdated Show resolved Hide resolved
CHANGES.txt Outdated Show resolved Hide resolved
Copy link
Contributor

@asonnenschein asonnenschein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Could you please fill out the MR description before merging?

@emma-steuer emma-steuer merged commit c42fb22 into main Apr 4, 2024
10 checks passed
@emma-steuer emma-steuer deleted the emma/hosting3 branch April 4, 2024 20:05
@emma-steuer emma-steuer mentioned this pull request Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants