Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: Pin httpx to v0.27.2 #1080

Merged
merged 3 commits into from
Dec 3, 2024
Merged

Hotfix: Pin httpx to v0.27.2 #1080

merged 3 commits into from
Dec 3, 2024

Conversation

asonnenschein
Copy link
Contributor

The most recent release of httpx v0.28.0 breaks all of our test pipelines across new and existing PRs with AllMockedAssertionError.

This PR pins httpx to v0.27.2, which is the version that immediately precedes v0.28.0. We should keep httpx pinned to v0.27.2 until the issue is resolved to ensure that our CI pipelines are not blocked.

respx ticket - lundberg/respx#277
possible fix - lundberg/respx#278

I am subscribed to both of the above respx ticket and PR, and will plan to follow up and configure httpx to pick up the latest version after the issue is resolved.

Copy link
Member

@ischneider ischneider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine but in the future, consider a min/max version specifier ... e.g. <0.28.0,>=0.23.0

@asonnenschein
Copy link
Contributor Author

I think this is fine but in the future, consider a min/max version specifier ... e.g. <0.28.0,>=0.23.0

@ischneider Good idea! Updated.

@asonnenschein asonnenschein merged commit e1036c7 into main Dec 3, 2024
9 checks passed
@asonnenschein asonnenschein deleted the hotfix/pin-httpx branch December 3, 2024 16:40
@lundberg
Copy link

RESPX version 0.22.0 released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants