Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder list kwargs to maintain consistency between releases #1082

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

HenryW95
Copy link
Contributor

@HenryW95 HenryW95 commented Dec 9, 2024

Related Issue(s):

DND-1610

Proposed Changes:

Not intended for changelog:

  1. Updates the kwarg order for the orders & subscriptions list method so that the order of existing kwargs (prior to the latest release) remain the same.
  2. Preps CHANGES.txt for release 2.12.0

PR Checklist:

  • This PR is as small and focused as possible
  • If this PR includes proposed changes for inclusion in the changelog, the title of this PR summarizes those changes and is ready for inclusion in the Changelog.
  • I have updated docstrings for function changes and docs in the 'docs' folder for user interface / behavior changes
  • This PR does not break any examples or I have updated them

@mentions for Notifications:
@ischneider @asonnenschein

@asonnenschein
Copy link
Contributor

LGTM! Kind of an odd pattern, but we we need to promote backwards compatibility and the method as originally defined is a bit restricting...

@HenryW95 HenryW95 merged commit be50c3a into main Dec 9, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants