-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code snippets for all APIs #939
base: maint-2.0
Are you sure you want to change the base?
Conversation
… cancel orders is broken.
@kevinlacaille I've realized a complication for testing against the production APIs: the test runner can only access saved searches and orders that it has made using the same credentials. It looks to me like your tests rely on your own saved searches and orders and that's not going to work. So it looks like you'll have to have a snippet to make a search, then get that search's id to go back to it. Same for orders. |
@kevinlacaille the main source of errors in the new tests is that the clients are pointed at the production API while the credentials stored in GitHub are for staging. See https://github.com/planetlabs/planet-client-python/actions/runs/5525726227/jobs/10079664599#step:5:616. I think we should reconsider running these snippets against our API. It's not very complicated for the Data API. But it gets more complicated for APIs that are stateful. Is it going to be feasible to keep making and downloading orders every time these tests run? Not to mention subscriptions, which need a cloud destination. |
NOTE: Maybe add in CONTRIBUTING.md on how to add to the snippets if a new function is added or if functionality changes. |
Related Issue(s):
Closes #540 #937
Proposed Changes:
For inclusion in changelog (if applicable):
Not intended for changelog:
Diff of User Interface
Old behavior:
N/A
New behavior:
N/A
PR Checklist:
(Optional) @mentions for Notifications:
@jreiberkyle