Support for CSV formatted results of subscriptions #981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgillies
commented
Jul 11, 2023
| # retry logic for HTTP requests, but does not handle errors | ||
| # during streaming. We may want to consider a retry decorator | ||
| # for this entire method a la stamina: | ||
| # https://github.com/hynek/stamina. |
Contributor
Author
There was a problem hiding this comment.
I think that our model for retrying requests doesn't cover streaming cases.
Retrying can wait until after 2.1.0.
|
Thanks. Using this via Are we clear in the documentation about how to get the output into a CSV file? I think we have users for which that might not be obvious. |
cpaulik
approved these changes
Jul 11, 2023
| async with Session() as session: | ||
| client = SubscriptionsClient(session, base_url=TEST_URL) | ||
| results = [res async for res in client.get_results_csv("42")] | ||
| import csv |
Contributor
There was a problem hiding this comment.
I'm surprised yapf doesn't care about this import's placement.
Contributor
Author
|
@guyon-planet in the future, let me merge these. I have a couple changes to make yet. |
Merged
Contributor
|
@sgillies, sorry about that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #933. The big choice here is to make CSV format access its own method instead of a flag on the existing method. I feel like this is warranted by the API split between JSON (paged) and CSV (not paged).
Sanity check @kevinlacaille @cpaulik ?