Merge pull request #90 from planetscale/fix-tinyint-schema

fix tinyint schema detection
planetscale · Nov 7, 2023 · 5baac4f · 5baac4f
2 parents 8017ce1 + da2703a
commit 5baac4f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/cmd/internal/planetscale_edge_database.go b/cmd/internal/planetscale_edge_database.go
@@ -134,7 +134,7 @@ func getJsonSchemaType(mysqlType string, treatTinyIntAsBoolean bool) PropertyTyp
 			return PropertyType{Type: "boolean"}
 		}
 		return PropertyType{Type: "number", AirbyteType: "integer"}
-	case strings.HasPrefix(mysqlType, "int"), strings.HasPrefix(mysqlType, "smallint"), strings.HasPrefix(mysqlType, "mediumint"), strings.HasPrefix(mysqlType, "bigint"):
+	case strings.HasPrefix(mysqlType, "int"), strings.HasPrefix(mysqlType, "smallint"), strings.HasPrefix(mysqlType, "mediumint"), strings.HasPrefix(mysqlType, "bigint"), strings.HasPrefix(mysqlType, "tinyint"):
 		return PropertyType{Type: "number", AirbyteType: "integer"}
 	case strings.HasPrefix(mysqlType, "decimal"), strings.HasPrefix(mysqlType, "double"), strings.HasPrefix(mysqlType, "float"):
 		return PropertyType{Type: "number"}

diff --git a/cmd/internal/planetscale_edge_database_test.go b/cmd/internal/planetscale_edge_database_test.go
@@ -224,6 +224,12 @@ func TestDiscover_CanPickRightAirbyteType(t *testing.T) {
 			JSONSchemaType: "number",
 			AirbyteType:    "integer",
 		},
+		{
+			MysqlType:             "tinyint",
+			JSONSchemaType:        "number",
+			AirbyteType:           "integer",
+			TreatTinyIntAsBoolean: true,
+		},
 		{
 			MysqlType:             "tinyint(1)",
 			JSONSchemaType:        "boolean",