Merge pull request #31 from planetscale/iheanyi/throw-error-from-refresh

Do not swallow errors from refreshing
planetscale · Aug 11, 2022 · 52e73b2 · 52e73b2
2 parents 2e6fb30 + 2cca3ee
commit 52e73b2
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 9 deletions.
diff --git a/__tests__/index.test.ts b/__tests__/index.test.ts
@@ -353,8 +353,7 @@ describe('refresh', () => {
   test('it sets the session variable when true', async () => {
     const connection = connect(config)
     mockPool.intercept({ path: CREATE_SESSION_PATH, method: 'POST' }).reply(200, JSON.stringify(mockSession))
-    const got = await connection.refresh()
-    expect(got).toEqual(true)
+    await connection.refresh()
   })
 })
 

diff --git a/src/index.ts b/src/index.ts
@@ -120,13 +120,8 @@ export class Connection {
     }
   }
 
-  async refresh(): Promise<boolean> {
-    try {
-      await this.createSession()
-      return true
-    } catch {
-      return false
-    }
+  async refresh(): Promise<void> {
+    await this.createSession()
   }
 
   private async createSession(): Promise<QuerySession> {