Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change to generic type for ExecutedQuery #151

Closed
wants to merge 1 commit into from

Conversation

yutak23
Copy link
Contributor

@yutak23 yutak23 commented Nov 28, 2023

This ought to fix #150.

This change allows you to define a type for an object if you have an array of rows generated as an 'object'.
As a result, properties will be suggested as described in the issue, and you will not have to access properties for any.

I don't think we will have to worry about the ESLint error Unsafe member access .id on an any value.(https://typescript-eslint.io/rules/no-unsafe-member-access/).

@ayrton
Copy link
Contributor

ayrton commented Dec 13, 2023

@yutak23 I've merged your changes into #154. I'm going to close this PR in favor of that one for now because it goes a little deeper into type correctness.

Could you verify this solves the issue you were having?

@ayrton ayrton closed this Dec 13, 2023
@yutak23
Copy link
Contributor Author

yutak23 commented Dec 14, 2023

@yutak23 I've merged your changes into #154. I'm going to close this PR in favor of that one for now because it goes a little deeper into type correctness.

Could you verify this solves the issue you were having?

@ayrton, Yes, I think that fix will solve my problem. Thank you very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] A type can be defined for rows in the query result
2 participants