Disable CGO usage in builds #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Lord <mattalord@gmail.com>
mattlord
added
Backport to: release-2.8
frouioui
approved these changes
Oct 9, 2023
deepthi
approved these changes
Oct 9, 2023
Signed-off-by: Matt Lord <mattalord@gmail.com>
mattlord
removed
Backport to: release-2.8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vitess has not used CGO since v15 where our usage of the native sqlite C library was replaced: vitessio/vitess#12214
We should not build the operator using CGO as it will not run on platforms that have an older glibc version than the one used on the golang container image used for the build.
This also moves the backup and restore test to using the default/
mysql80images intest/endtoend/operator/101_initial_cluster_backup.yaml. This was the only test still using themysql57images and this moves everything to 8.0 (MySQL 5.7 is EOL next month).