VReplication: more unrecoverable error codes (vitessio#10559) (vitess…

…io#781)

* VReplication: more unrecoverable error codes

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* correct path for test files

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

go/mysql/constants.go

@@ -535,6 +535,7 @@ const (
 	ERTableNameNotAllowedHere      = 1250
 	ERQueryInterrupted             = 1317
 	ERTruncatedWrongValueForField  = 1366
+	ERIllegalValueForType          = 1367
 	ERDataTooLong                  = 1406
 	ErrWrongValueForType           = 1411
 	ERWarnDataTruncated            = 1265

go/test/endtoend/onlineddl/vrepl_suite/testdata/fail-utf8-to-datetime-2/alter

@@ -0,0 +1 @@
+modify column t datetime

go/test/endtoend/onlineddl/vrepl_suite/testdata/fail-utf8-to-datetime-2/create.sql

@@ -0,0 +1,23 @@
+drop table if exists onlineddl_test;
+create table onlineddl_test (
+  id int auto_increment,
+  t varchar(128) charset utf8 collate utf8_general_ci,
+  primary key(id)
+) auto_increment=1;
+
+insert into onlineddl_test values (null, '2021-12-21 12:21:11');
+
+drop event if exists onlineddl_test;
+delimiter ;;
+create event onlineddl_test
+  on schedule every 1 second
+  starts current_timestamp
+  ends current_timestamp + interval 60 second
+  on completion not preserve
+  enable
+  do
+begin
+  insert into onlineddl_test values (null, '2021-12-21 12:21:12');
+  insert into onlineddl_test values (null, '2021-12-21 12:21:13');
+  insert into onlineddl_test values (null, '');
+end ;;

go/test/endtoend/onlineddl/vrepl_suite/testdata/fail-utf8-to-datetime-2/expect_failure

@@ -0,0 +1 @@
+Incorrect datetime value

go/test/endtoend/onlineddl/vrepl_suite/testdata/fail-utf8-to-datetime/alter

@@ -0,0 +1 @@
+modify column t datetime

go/test/endtoend/onlineddl/vrepl_suite/testdata/fail-utf8-to-datetime/create.sql

@@ -0,0 +1,23 @@
+drop table if exists onlineddl_test;
+create table onlineddl_test (
+  id int auto_increment,
+  t varchar(128) charset utf8 collate utf8_general_ci,
+  primary key(id)
+) auto_increment=1;
+
+insert into onlineddl_test values (null, '2021-12-21 12:21:11');
+
+drop event if exists onlineddl_test;
+delimiter ;;
+create event onlineddl_test
+  on schedule every 1 second
+  starts current_timestamp
+  ends current_timestamp + interval 60 second
+  on completion not preserve
+  enable
+  do
+begin
+  insert into onlineddl_test values (null, '2021-12-21 12:21:12');
+  insert into onlineddl_test values (null, '2021-12-21 12:21:13');
+  insert into onlineddl_test values (null, 'something else');
+end ;;

go/test/endtoend/onlineddl/vrepl_suite/testdata/fail-utf8-to-datetime/expect_failure

@@ -0,0 +1 @@
+Incorrect datetime value

go/test/endtoend/onlineddl/vrepl_suite/testdata/utf8-to-datetime/alter

@@ -0,0 +1 @@
+modify column t datetime

go/test/endtoend/onlineddl/vrepl_suite/testdata/utf8-to-datetime/create.sql

@@ -0,0 +1,23 @@
+drop table if exists onlineddl_test;
+create table onlineddl_test (
+  id int auto_increment,
+  t varchar(128) charset utf8 collate utf8_general_ci,
+  primary key(id)
+) auto_increment=1;
+
+insert into onlineddl_test values (null, '2021-12-21 12:21:11');
+
+drop event if exists onlineddl_test;
+delimiter ;;
+create event onlineddl_test
+  on schedule every 1 second
+  starts current_timestamp
+  ends current_timestamp + interval 60 second
+  on completion not preserve
+  enable
+  do
+begin
+  insert into onlineddl_test values (null, '2021-12-21 12:21:12');
+  insert into onlineddl_test values (null, '2021-12-21 12:21:13');
+  insert into onlineddl_test values (null, '2021-12-21 12:21:14');
+end ;;

go/vt/vttablet/tabletmanager/vreplication/utils.go

@@ -142,7 +142,9 @@ func isUnrecoverableError(err error) bool {
 		mysql.ERWarnDataOutOfRange,
 		mysql.ERDataTooLong,
 		mysql.ERWarnDataTruncated,
+		mysql.ERTruncatedWrongValue,
 		mysql.ERTruncatedWrongValueForField,
+		mysql.ERIllegalValueForType,
 		mysql.ErrWrongValueForType,
 		mysql.ErrCantCreateGeometryObject,
 		mysql.ErrGISDataWrongEndianess,

go/vt/vttablet/tabletserver/tabletserver.go

@@ -1501,7 +1501,7 @@ func convertErrorCode(err error) vtrpcpb.Code {
 		mysql.ERCantAggregate3Collations, mysql.ERCantAggregateNCollations, mysql.ERVariableIsNotStruct, mysql.ERUnknownCollation, mysql.ERWrongNameForIndex,
 		mysql.ERWrongNameForCatalog, mysql.ERBadFTColumn, mysql.ERTruncatedWrongValue, mysql.ERTooMuchAutoTimestampCols, mysql.ERInvalidOnUpdate, mysql.ERUnknownTimeZone,
 		mysql.ERInvalidCharacterString, mysql.ERIllegalReference, mysql.ERDerivedMustHaveAlias, mysql.ERTableNameNotAllowedHere, mysql.ERDataTooLong, mysql.ERDataOutOfRange,
-		mysql.ERTruncatedWrongValueForField:
+		mysql.ERTruncatedWrongValueForField, mysql.ERIllegalValueForType:
 		errCode = vtrpcpb.Code_INVALID_ARGUMENT
 	case mysql.ERSpecifiedAccessDenied:
 		errCode = vtrpcpb.Code_PERMISSION_DENIED