[Fix] Make section and cell view models diffable by default #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Section and cell view models are now diffable by default.
They have default values for `diffingKey`, but clients should be customizing these for their needs.
- `CollectionSectionViewModel` protocol now inherits from `DiffableViewModel` protocol
- `CollectionCellViewModel` protocol now inherits from `DiffableViewModel` protocol
- ` TableSectionViewModel` protocol now inherits from `DiffableViewModel` protocol
- `TableCellViewModel` protocol now inherits from `DiffableViewModel` protocol
Closes #114
Generated by 🚫 Danger |
asmallteapot
previously approved these changes
Jul 7, 2018
|
@asmallteapot Yeah, I wanted this to be non-optional (also required by the |
anayini
reviewed
Jul 9, 2018
CHANGELOG.md
Outdated
| ### Changed | ||
|
|
||
| - Section and cell view models are now diffable by default. ([#119](https://github.com/plangrid/ReactiveLists/pull/119), [@jessesquires](https://github.com/jessesquires)) | ||
| Each provide default values for `diffingKey`, but you should be customize them for your own needs or opt-out of automatic diffing. |
There was a problem hiding this comment.
"but you should be" -> "but you can"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They have default values for
diffingKey, but clients should be customizing these for their needs.CollectionSectionViewModelprotocol now inherits fromDiffableViewModelprotocolCollectionCellViewModelprotocol now inherits fromDiffableViewModelprotocolTableSectionViewModelprotocol now inherits fromDiffableViewModelprotocolTableCellViewModelprotocol now inherits fromDiffableViewModelprotocolCloses #114